Comments on: The committer model in practice http://warrenseen.com/blog/2006/03/28/the-committer-model-in-practice/ freelance software developer Tue, 03 Aug 2010 19:04:01 +0000 http://wordpress.org/?v=2.8.4 hourly 1 By: warren http://warrenseen.com/blog/2006/03/28/the-committer-model-in-practice/comment-page-1/#comment-47 warren Tue, 28 Mar 2006 11:51:19 +0000 http://warrenseen.com/blog/2006/03/28/the-committer-model-in-practice/#comment-47 One of the things we found useful with subversion was to use the post-commit hook that will email you whenever a checkin occurs (well in practice, it emails the developer mailing list) This is a great avenue for impromptu code review when you can look over the code that's been checked in and discuss any issues with the rest of the list. They're also useful to some extent in monitoring the rest of the team's progress. I'm wary however of letting management folks get these emails, they tend to try and derive naive metrics from them, eg "how come X has committed 100 lines of code when Y has only committed 1 line today" even though person Y may have been slaving away all day to reproduce an obscure bug and just checked in a critical fix for it. One of the things we found useful with subversion was to use the post-commit hook that will email you whenever a checkin occurs (well in practice, it emails the developer mailing list) This is a great avenue for impromptu code review when you can look over the code that’s been checked in and discuss any issues with the rest of the list.

They’re also useful to some extent in monitoring the rest of the team’s progress. I’m wary however of letting management folks get these emails, they tend to try and derive naive metrics from them, eg

“how come X has committed 100 lines of code when Y has only committed 1 line today” even though person Y may have been slaving away all day to reproduce an obscure bug and just checked in a critical fix for it.

]]> By: Mark Cohen http://warrenseen.com/blog/2006/03/28/the-committer-model-in-practice/comment-page-1/#comment-46 Mark Cohen Tue, 28 Mar 2006 10:59:08 +0000 http://warrenseen.com/blog/2006/03/28/the-committer-model-in-practice/#comment-46 I totally agree with your sentiments and observations. We recently migrated to Subversion and now work with a trunk and a release branch, and by evolution ended up at almost the exact working rules you outlined in the points 1 to 3 above. We face some problems with skill level, cut-and-paste programming and oddly enough trust similar to what you outline above too. I totally agree with your sentiments and observations. We recently migrated to Subversion and now work with a trunk and a release branch, and by evolution ended up at almost the exact working rules you outlined in the points 1 to 3 above. We face some problems with skill level, cut-and-paste programming and oddly enough trust similar to what you outline above too.

]]>